- 
          
- 
        Couldn't load subscription status. 
- Fork 10.9k
[Optim] Compute multimodal hash only once per item #17314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
| 👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run  Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add  🚀 | 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
0906613    to
    b557fab      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM!
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Introduce
ProcessingCache.get_itemto simultaneously get the hash and the corresponding multi-modal item from the cache, so that we don't have to recompute the hash again inBaseMultiModalProcessor.apply.Notes:
ProcessingCache.get_itemto avoid merge conflict with [Metrics] Log multi-modal cache stats #16478 .BaseMultiModalProcessor._cached_apply_hf_processorandEncDecMultiModalProcessor.applyto promote code reuse.enable_sanity_checksparameter toBaseMultiModalProcessor.__init__has been removed as it's not that useful.