Skip to content

Conversation

@hongxiayang
Copy link
Collaborator

@hongxiayang hongxiayang commented Apr 28, 2025

Fix the case where if interleave-moe-layer-step is 0, the code will throw div by 0 error.

Signed-off-by: Hongxia Yang <hongxia.yang@amd.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hongxiayang hongxiayang requested a review from houseroad April 28, 2025 22:31
Signed-off-by: Hongxia Yang <hongxia.yang@amd.com>
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with #17315?

@hongxiayang
Copy link
Collaborator Author

Let's go with #17315?

sure. seems these two PRS are exactly the same. haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants