Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Apr 29, 2025

I'm seeing these failures from my other PR #16859, but they don't seem to be related to PyTorch 2.7.0 release. They seem to come from #13305 with the issue on Triton triton-lang/triton#2266. I have seen similar a PR from PyTorch about this pytorch/pytorch#147765.

The PR attempts to fix the failed tests accordingly.

huydhn added 2 commits April 29, 2025 02:30
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
@vllm-bot vllm-bot merged commit 88fcf00 into vllm-project:main Apr 30, 2025
41 of 43 checks passed
@huydhn
Copy link
Contributor Author

huydhn commented Apr 30, 2025

This fixes some spec decode failures but not all of them. Specifically, https://github.com/vllm-project/vllm/blob/main/.buildkite/test-pipeline.yaml#L283 has been fixed, but there are more failures from the next line VLLM_ATTENTION_BACKEND=FLASH_ATTN pytest -v -s spec_decode --ignore=spec_decode/e2e/test_multistep_correctness.py --ignore=spec_decode/e2e/test_mtp_correctness.py. I have been debugging them and the root cause points to #17084. cc @WoosukKwon

radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants