Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented May 2, 2025

Also sum gpu blocks across DP ranks when reporting the num_gpu_blocks metric.

Both introduced by #15755

There is a test for this but it's not running on V1 yet. Will look at changing that: https://github.com/vllm-project/vllm/blob/main/tests/metrics/test_metrics.py

@njhill njhill added the bug Something isn't working label May 2, 2025
@github-actions
Copy link

github-actions bot commented May 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 2, 2025
Also sum gpu blocks across DP ranks when reporting the num_gpu_blocks metric.

Signed-off-by: Nick Hill <nhill@redhat.com>
@njhill njhill force-pushed the fix-disable-log-stats branch from 371d45c to 5913eb8 Compare May 2, 2025 19:40
Signed-off-by: Nick Hill <nhill@redhat.com>
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) May 2, 2025 19:44
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 2, 2025
@njhill
Copy link
Member Author

njhill commented May 3, 2025

I think the test failure is also happening on main. I will look into that too

@robertgshaw2-redhat robertgshaw2-redhat merged commit 3d13ca0 into vllm-project:main May 8, 2025
50 checks passed
@njhill njhill deleted the fix-disable-log-stats branch May 8, 2025 13:24
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
iboiko-habana added a commit to HabanaAI/vllm-fork that referenced this pull request May 13, 2025
afierka-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request May 14, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
)

Signed-off-by: Nick Hill <nhill@redhat.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants