Skip to content

[Bugfix] Prioritize dtype in root config before checking text config #17629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

[Bugfix] Prioritize dtype in root config before checking text config #17629

merged 1 commit into from
May 4, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented May 4, 2025 •
edited by github-actions bot
Loading

We should still prioritze the dtype defined in the root config before checking text_config or vision_config. Sorry I missed this when reviewing #17105!

FIX #17622

@DarkLight1337
[Bugfix] Prioritize dtype in root config before checking text config
3c4b939 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 4, 2025
@DarkLight1337 DarkLight1337 requested a review from hmellor May 4, 2025 09:19
@DarkLight1337 DarkLight1337 added this to the v0.9.0 milestone May 4, 2025
@github-actions
Copy link

github-actions bot commented May 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request May 4, 2025
Closed
1 task
hmellor
hmellor approved these changes May 4, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@hmellor hmellor enabled auto-merge (squash) May 4, 2025 09:47
@hmellor hmellor merged commit 2858830 into vllm-project:main May 4, 2025
51 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-dtype branch May 4, 2025 12:43
@chaunceyjiang chaunceyjiang mentioned this pull request May 6, 2025
Open
1 task
This was referenced May 6, 2025
Closed
Closed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Prioritize dtype in root config before checking text config (v…
0c709c1 
…llm-project#17629)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@DarkLight1337 @mawong-amd
[Bugfix] Prioritize dtype in root config before checking text config (v…
2830778 
…llm-project#17629)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@DarkLight1337
[Bugfix] Prioritize dtype in root config before checking text config (v…
ee9a6db 
…llm-project#17629)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

v0.9.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Gemma3 models always return empty output

2 participants

@DarkLight1337 @hmellor