-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Convert .buildkite to ruff format
#17656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert .buildkite to ruff format
#17656
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
How does this work for PR touching conflicting files? Is there a process for PR author to conduct a smooth rebase? |
|
I would probably recommend that they run Then, when they rebase, both sides of the diff will be |
|
More than one week has passed since the RFC #17657 so let's start! |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
If we are converting directory
x:x, we add a localpyproject.tomlwhich:isortto use theblackprofileruff's line length to 88 (it's own default)xto the list of files to runruff-formaton in.pre-commit-config.yamlxto the list of ignores in theyapfconfig in the rootpyproject.toml