Only depend on importlib-metadata for Python < 3.10 #17776
Conversation
The stdlib module `importlib.metadata` replaces the PyPI package `importlib-metadata` since Python 3.10. The function `vllm.plugins.load_plugins_by_group()` is the only place that imports `importlib_metadata`. The import is conditional for `sys.version_info < (3, 10)`. Signed-off-by: Christian Heimes <christian@python.org>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Thanks for making the dependencies more precise!
github-actions
bot
added
the
ready
Signed-off-by: Christian Heimes <christian@python.org> Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
Signed-off-by: Christian Heimes <christian@python.org> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Signed-off-by: Christian Heimes <christian@python.org>
Signed-off-by: Christian Heimes <christian@python.org> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
3 participants
The stdlib module
importlib.metadatareplaces the PyPI packageimportlib-metadatasince Python 3.10. The functionvllm.plugins.load_plugins_by_group()is the only place that importsimportlib_metadata. The import is conditional forsys.version_info < (3, 10).