-
-
Couldn't load subscription status.
- Fork 10.9k
Improve exception reporting in MP engine #17800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
"raise e from None" means changing the error bubble narrative from "another exception caused by e" to "exception e was raised and we forward it up" Signed-off-by: Vadim Markovtsev <vadim@poolside.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vmarkovtsev. This is on the V0 path - could I ask which version of vLLM you are using and and whether you're using V0 mode intentionally and if so why?
|
Sure, we are on the bleeding edge but with Neuron. On our custom Neuron backend which is a complete rewrite fwiw, but it shouldn't matter, as I understand. |
Signed-off-by: Vadim Markovtsev <vadim@poolside.ai> Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
Signed-off-by: Vadim Markovtsev <vadim@poolside.ai> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Signed-off-by: Vadim Markovtsev <vadim@poolside.ai>
This PR is a follow-up to vllm-project#17800 We should `raise e from None`, otherwise, re-raised error is considered new while processing the original one. Signed-off-by: Vadim Markovtsev <vadim@poolside.ai>
Signed-off-by: Vadim Markovtsev <vadim@poolside.ai> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
"raise e from None" means changing the error bubble narrative from "another exception caused by e" to "exception e was raised and we forward it up"