Skip to content

[Misc] add chatbox integration #17828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

[Misc] add chatbox integration #17828

merged 2 commits into from
May 8, 2025

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented May 8, 2025 •
edited by github-actions bot
Loading

Continue to add popular chatbox integration with vllm.

@reidliu41
[Misc] add chatbox integration
89dc0bc 
Signed-off-by: reidliu41 <reid201711@gmail.com>
@github-actions
Copy link

github-actions bot commented May 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 8, 2025
DarkLight1337
DarkLight1337 approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks for adding this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 8, 2025 05:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 8, 2025
@DarkLight1337 DarkLight1337 merged commit 53d0cb7 into vllm-project:main May 8, 2025
26 checks passed
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@reidliu41 @princepride
[Misc] add chatbox integration (vllm-project#17828)
f241ac3 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@reidliu41
[Misc] add chatbox integration (vllm-project#17828)
0bd042c 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@reidliu41 @mawong-amd
[Misc] add chatbox integration (vllm-project#17828)
c0f995a 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@reidliu41
[Misc] add chatbox integration (vllm-project#17828)
3367eb5 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 ywang96 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidliu41 @DarkLight1337 @ywang96