Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented May 8, 2025

As discussed in https://vllm-dev.slack.com/archives/C07QCGVDNUF/p1746687303802249?thread_ts=1745944078.067259&cid=C07QCGVDNUF

I decided not to add regression tests because the default behavior of use_fast=None (which occurs when use_fast fails to be propagated) will change in transformers v4.52

…ocessor

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested review from Isotr0py and ywang96 May 8, 2025 07:35
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 8, 2025
@github-actions
Copy link

github-actions bot commented May 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) May 8, 2025 07:44
@vllm-bot vllm-bot merged commit 015815f into vllm-project:main May 8, 2025
53 of 57 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-qwen2vl-fast branch May 8, 2025 12:39
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
…sor (vllm-project#17838)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…sor (vllm-project#17838)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
…sor (vllm-project#17838)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
…sor (vllm-project#17838)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants