Skip to content

Conversation

@russellb
Copy link
Member

@russellb russellb commented May 8, 2025

This change is related to #17490. This test didn't run on that PR, so
the failure was missed. This code currently relies on the pickle
fallback, so pickle support must be enabled to use it for now.

Signed-off-by: Russell Bryant rbryant@redhat.com

This change is related to vllm-project#17490. This test didn't run on that PR, so
the failure was missed. This code currently relies on the pickle
fallback, so pickle support must be enabled to use it for now.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@github-actions
Copy link

github-actions bot commented May 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 8, 2025 13:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 8, 2025
@DarkLight1337 DarkLight1337 merged commit ec54d73 into vllm-project:main May 8, 2025
37 of 39 checks passed
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants