Skip to content

[Doc] remove visible token in doc #17884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

[Doc] remove visible token in doc #17884

merged 1 commit into from
May 9, 2025

Conversation

@yma11
Copy link
Contributor

@yma11 yma11 commented May 9, 2025 •
edited by github-actions bot
Loading

remove visible token in doc which will cause security failure.

@yma11
[Doc] remove visible token in doc
1b3ff82 
Signed-off-by: yan <yanma1@habana.ai>
@github-actions
Copy link

github-actions bot commented May 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yma11
Copy link
Contributor Author

yma11 commented May 9, 2025

@dr75 FYI. @DarkLight1337 can you help take a look?

@mergify mergify bot added the documentation Improvements or additions to documentation label May 9, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 9, 2025 06:08
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 9, 2025
@vllm-bot vllm-bot merged commit ff8c400 into vllm-project:main May 9, 2025
34 of 38 checks passed
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@yma11 @princepride
[Doc] remove visible token in doc (vllm-project#17884)
04b073c 
Signed-off-by: yan <yanma1@habana.ai>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@yma11
[Doc] remove visible token in doc (vllm-project#17884)
74280f0 
Signed-off-by: yan <yanma1@habana.ai>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@yma11 @mawong-amd
[Doc] remove visible token in doc (vllm-project#17884)
de02245 
Signed-off-by: yan <yanma1@habana.ai>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@yma11
[Doc] remove visible token in doc (vllm-project#17884)
7de0c5f 
Signed-off-by: yan <yanma1@habana.ai>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
@yma11 yma11 deleted the rm-token branch May 27, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yma11 @jeejeelee @DarkLight1337 @vllm-bot