Skip to content

[v1] Rename specialized_manager.py to single_type_kv_cache_manager.py #17946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

[v1] Rename specialized_manager.py to single_type_kv_cache_manager.py #17946

merged 1 commit into from
May 10, 2025

Conversation

@heheda12345
Copy link
Collaborator

#17474 changes class SpecializedManager to class SingleTypeKVCacheManager. This PR renames that file to ensure the consistency.

@heheda12345
rename
766c49b 
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 10, 2025
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label May 10, 2025
@WoosukKwon WoosukKwon merged commit ca66a16 into vllm-project:main May 10, 2025
35 of 39 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@heheda12345
[v1] Rename specialized_manager.py to single_type_kv_cache_manager.py (…
be26d3b 
…vllm-project#17946)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@heheda12345 @mawong-amd
[v1] Rename specialized_manager.py to single_type_kv_cache_manager.py (…
0fb6242 
…vllm-project#17946)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@heheda12345
[v1] Rename specialized_manager.py to single_type_kv_cache_manager.py (…
5782982 
…vllm-project#17946)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heheda12345 @WoosukKwon