Skip to content

Conversation

@ztang2370
Copy link
Contributor

@ztang2370 ztang2370 commented May 11, 2025

Update the pip install dev requirements instruction in the doc, following up on #17576.
Running pip install -r requirements/dev.txt will give error:

ERROR: Could not find a version that satisfies the requirement torch==2.7.0+cu128 (from versions: 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.5.0, 2.5.1, 2.6.0, 2.7.0)
ERROR: No matching distribution found for torch==2.7.0+cu128

Signed-off-by: zt2370 <ztang2370@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 11, 2025

```bash
pip install -r requirements/dev.txt
pip install -r requirements/dev.txt --extra-index-url https://download.pytorch.org/whl/cu128
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only applies for developers using CUDA though. How about other backends?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out! However, since torch==2.7.0+cu128 is now specified in requirements/test.txt (updated via #17576 last week), installing it requires access to the PyTorch CUDA 12.8 wheels via pip install -r requirements/dev.txt --extra-index-url https://download.pytorch.org/whl/cu128. I can think of 2 options:

  1. Make requirements/test.txt backend-agnostic:
    Change requirements/test.txt back to use a backend-neutral spec:
    torch==2.7.0
    Developers using cuda can then install their desired CUDA variant manually, e.g.:
    pip install torch==2.7.0+cu128 --extra-index-url https://download.pytorch.org/whl/cu128
    Add a note in the README or contributing guide like:

Note: If you're using CUDA and install torch==2.7.0 without a specific build, it will default to the CUDA 12.6 variant. However, CUDA 12.6 builds currently have known issues. It’s recommended to install the CUDA 12.8 build explicitly. See PyTorch installation guide.

  1. Keep torch==2.7.0+cu128, but document clearly:
    If we keep the CUDA-specific spec in requirements/test.txt, we should update the doc to say:
    pip install -r requirements/dev.txt --extra-index-url https://download.pytorch.org/whl/cu128
    And add a note:

Note: This assumes you're using CUDA 12.8. For other environments (CPU-only, different CUDA versions, ROCm), you may need to adjust the torch installation manually.

Let me know which direction you'd prefer. I'm happy to update the PR accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: zt2370 <ztang2370@gmail.com>
Copy link
Contributor Author

@ztang2370 ztang2370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated by adding comment

```bash
pip install -r requirements/dev.txt
# The following command assumes CUDA 12.8. For CPU-only, other CUDA versions,
# or ROCm, etc., adjust the torch installation as needed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, I added the comment to make it clearer.
@DarkLight1337 @houseroad @mgoin

@mergify
Copy link

mergify bot commented May 23, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ztang2370.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 23, 2025
@ztang2370 ztang2370 closed this Jun 15, 2025
@ztang2370 ztang2370 deleted the patch-1 branch June 15, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants