Skip to content

cleanup invalid prints #18050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

cleanup invalid prints #18050

merged 1 commit into from
May 13, 2025

Conversation

@calvin0327
Copy link
Contributor

@calvin0327 calvin0327 commented May 13, 2025 •
edited by github-actions bot
Loading

cleanup invalid prints.

@calvin0327
cleanup invalid prints
d810d47 
Signed-off-by: calvin chen <120380290@qq.com>
@github-actions
Copy link

github-actions bot commented May 13, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label May 13, 2025
@vllm-bot vllm-bot merged commit 4854572 into vllm-project:main May 13, 2025
9 of 19 checks passed
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@calvin0327 @mawong-amd
cleanup invalid prints (vllm-project#18050)
8fb4349 
Signed-off-by: calvin chen <120380290@qq.com>
@NickLucche NickLucche mentioned this pull request May 15, 2025
Closed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@calvin0327
cleanup invalid prints (vllm-project#18050)
ef6b485 
Signed-off-by: calvin chen <120380290@qq.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calvin0327 @jeejeelee @vllm-bot