Skip to content

Conversation

@RichardoMrMu
Copy link
Contributor

following this issue #17794, and #10582 this issue ([P2] Make it work with tracing too (there's some request level stats that tracing needs, like queue time, ttft). These request level metric should be possible to be surfaced in v1 too.). I make engine v1 to generate model tracing span.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 13, 2025
@RichardoMrMu RichardoMrMu force-pushed the main branch 2 times, most recently from 16c50eb to e065dfd Compare May 13, 2025 12:20
@mergify
Copy link

mergify bot commented May 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @RichardoMrMu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify
Copy link

mergify bot commented May 23, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @RichardoMrMu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 23, 2025
@hcyezhang
Copy link
Contributor

hcyezhang commented Jun 5, 2025

@RichardoMrMu gentle ping on this PR, we are really looking forward to using v1 tracing :)

@mergify mergify bot removed the needs-rebase label Jun 5, 2025
@xiaoziv
Copy link

xiaoziv commented Jun 6, 2025

Is there any update on this PR? We are ready to use the trace feature and would appreciate it if you could expedite the review. Thank you very much. @WoosukKwon @robertgshaw2-redhat @njhill @ywang96 @comaniac @alexm-redhat

@ronensc
Copy link
Contributor

ronensc commented Jun 18, 2025

I pulled this PR to try it out and noticed the following warning in the logs:

WARNING 06-18 17:37:15 [arg_utils.py:1633] --otlp-traces-endpoint is not supported by the V1 Engine. Falling back to V0. 

To enable tracing with the V1 engine, I believe the --otlp-traces-endpoint flag should be removed from _raise_or_fallback():

vllm/vllm/engine/arg_utils.py

Lines 1373 to 1377 in 735a9de

# No OTLP observability so far.
if (self.otlp_traces_endpoint or self.collect_detailed_traces):
_raise_or_fallback(feature_name="--otlp-traces-endpoint",
recommend_to_remove=False)
return False

@ronensc
Copy link
Contributor

ronensc commented Jul 2, 2025

@RichardoMrMu, are you planning to continue with this PR and address the warning noted above?
FYI @gyliu513

@mergify
Copy link

mergify bot commented Jul 2, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @RichardoMrMu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 2, 2025
@hcyezhang
Copy link
Contributor

@RichardoMrMu, are you planning to continue with this PR and address the warning noted above? FYI @gyliu513
Hi @ronensc
I've chatted with @RichardoMrMu offline, I'll be taking over this PR from here :)
Your comments are addressed, plus some additional fixes.

@mergify mergify bot added documentation Improvements or additions to documentation ci/build deepseek Related to DeepSeek models frontend llama Related to Llama models multi-modality Related to multi-modality (#4194) performance Performance-related issues qwen Related to Qwen models rocm Related to AMD ROCm structured-output speculative-decoding labels Jul 2, 2025
@mergify mergify bot added the tpu Related to Google TPUs label Jul 2, 2025
@mergify
Copy link

mergify bot commented Jul 2, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @RichardoMrMu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build deepseek Related to DeepSeek models documentation Improvements or additions to documentation frontend llama Related to Llama models multi-modality Related to multi-modality (#4194) needs-rebase performance Performance-related issues qwen Related to Qwen models rocm Related to AMD ROCm speculative-decoding structured-output tool-calling v1

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants