-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[V1] feat:add engine v1 tracing #18069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
16c50eb to
e065dfd
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
|
This pull request has merge conflicts that must be resolved before it can be |
|
@RichardoMrMu gentle ping on this PR, we are really looking forward to using v1 tracing :) |
|
Is there any update on this PR? We are ready to use the trace feature and would appreciate it if you could expedite the review. Thank you very much. @WoosukKwon @robertgshaw2-redhat @njhill @ywang96 @comaniac @alexm-redhat |
|
I pulled this PR to try it out and noticed the following warning in the logs: To enable tracing with the V1 engine, I believe the Lines 1373 to 1377 in 735a9de
|
|
@RichardoMrMu, are you planning to continue with this PR and address the warning noted above? |
|
This pull request has merge conflicts that must be resolved before it can be |
|
|
This pull request has merge conflicts that must be resolved before it can be |
following this issue #17794, and #10582 this issue ([P2] Make it work with tracing too (there's some request level stats that tracing needs, like queue time, ttft). These request level metric should be possible to be surfaced in v1 too.). I make engine v1 to generate model tracing span.