Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented May 13, 2025

Test snippet

from vllm import LLM
from vllm.config import PoolerConfig
query = "who are tyout"
prompts = [
    f"query: {query}</s>",
    f"passage: {query} {query}</s>",
]
pooler_config = PoolerConfig(pooling_type="LAST", normalize=True)
model = LLM(
    model="intfloat/e5-mistral-7b-instruct",
    task="embed",
    enforce_eager=True,
    quantization="bitsandbytes",
)

outputs = model.embed(prompts)

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee jeejeelee requested review from DarkLight1337 and mgoin May 13, 2025 16:16
@DarkLight1337
Copy link
Member

Is there any existing model we can use to test this?

@jeejeelee
Copy link
Collaborator Author

_ No description provided. _

Is there any existing model we can use to test this?

We can use intfloat/e5-mistral-7b-instruct, I have updated the test snippet in the top comment

@DarkLight1337
Copy link
Member

Can you add this test to the CI?

@jeejeelee
Copy link
Collaborator Author

The reason I didn't add it was due to concerns about CI pressure. If you think related tests should be added, I'll implement it ASAP.

@DarkLight1337
Copy link
Member

The quantization model test is conditional so it should be fine to add it

jeejeelee added 2 commits May 19, 2025 13:43
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>

hf_model_kwargs = {"load_in_4bit": True}
hf_model_kwargs = dict(quantization_config=BitsAndBytesConfig(
load_in_4bit=True))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to avoid the warning below

The `load_in_4bit` and `load_in_8bit` arguments are deprecated and will be removed in the future versions. Please, pass a `BitsAndBytesConfig` object in `quantization_config` argument instead

@jeejeelee
Copy link
Collaborator Author

jeejeelee commented May 19, 2025

The quantization model test is conditional so it should be fine to add it

I have added the test @DarkLight1337

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 19, 2025 09:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 19, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
Copy link
Collaborator Author

It looks like we need to force merge

@vllm-bot vllm-bot merged commit 6781af5 into vllm-project:main May 19, 2025
61 of 64 checks passed
@jeejeelee jeejeelee deleted the fix-embeddding-bnb branch May 19, 2025 16:13
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants