Skip to content

Conversation

@lk-chen
Copy link
Collaborator

@lk-chen lk-chen commented May 13, 2025

In #17805, trust_remote_code was removed, and model_config was added as first argument. It broke ray-project/ray#52975.

Now other python code that relies on chat_utils.py need to:

resolve_format_kwargs = dict(
  ...
  model_config=model_config,
)
try:
    resolved = resolve_chat_template_content_format(**resolve_format_kwargs)
except TypeError:
    # resolve_chat_template_content_format changed API in 0.9.0, older version doesn't expect `model_config`
    resolve_format_kwargs.pop("model_config")
    resolve_format_kwargs["trust_remote_code"] = model_config.trust_remote_code
    resolved = resolve_chat_template_content_format(**resolve_format_kwargs)

Signed-off-by: Linkun <github@lkchen.net>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label May 13, 2025
Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Linkun <github@lkchen.net>
@lk-chen lk-chen force-pushed the add_missing_arg_chat_util branch from 4947764 to a8039cf Compare May 13, 2025 21:30
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Sorry for breaking your code, didn't realize this is actively being used downstream, since it's not part of the official API.

Signed-off-by: Linkun <github@lkchen.net>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 14, 2025 03:24
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 14, 2025
@vllm-bot vllm-bot merged commit 6685890 into vllm-project:main May 14, 2025
85 of 89 checks passed
@lk-chen lk-chen deleted the add_missing_arg_chat_util branch May 14, 2025 07:19
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
…ect#18098)

Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants