-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[Fix] Move "model_config" as keyword args in chat_utils.py #18098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Move "model_config" as keyword args in chat_utils.py #18098
Conversation
Signed-off-by: Linkun <github@lkchen.net>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Linkun <github@lkchen.net>
3fda9fc to
4947764
Compare
Signed-off-by: Linkun <github@lkchen.net>
4947764 to
a8039cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Sorry for breaking your code, didn't realize this is actively being used downstream, since it's not part of the official API.
Signed-off-by: Linkun <github@lkchen.net>
…ect#18098) Signed-off-by: Linkun <github@lkchen.net> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
In #17805,
trust_remote_codewas removed, andmodel_configwas added as first argument. It broke ray-project/ray#52975.Now other python code that relies on
chat_utils.pyneed to: