[V1] Update zmq socket creation in nixl connector #18148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While browsing this code, I noticed this code wasn't using the
make_zmq_sockethelper fromvllm.utils. Update it to use it.The benefits are:
though this part doesn't seem too relevant for how the current sockets
are used. I still think using the helper is a good best practice.
Fixing IPv6 support also required a fix to how the zmq path string is
constructed to wrap IPv6 addresses in square brackets before adding a
port number to the end.
Signed-off-by: Russell Bryant rbryant@redhat.com