Skip to content

Conversation

@russellb
Copy link
Member

While browsing this code, I noticed this code wasn't using the
make_zmq_socket helper from vllm.utils. Update it to use it.

The benefits are:

  • this fixes IPv6 support
  • Optimize buffer sizes based on system memory to improve throughput,
    though this part doesn't seem too relevant for how the current sockets
    are used. I still think using the helper is a good best practice.

Fixing IPv6 support also required a fix to how the zmq path string is
constructed to wrap IPv6 addresses in square brackets before adding a
port number to the end.

Signed-off-by: Russell Bryant rbryant@redhat.com

While browsing this code, I noticed this code wasn't using the
`make_zmq_socket` helper from `vllm.utils`. Update it to use it.

The benefits are:

- this fixes IPv6 support
- Optimize buffer sizes based on system memory to improve throughput,
  though this part doesn't seem too relevant for how the current sockets
  are used. I still think using the helper is a good best practice.

Fixing IPv6 support also required a fix to how the zmq path string is
constructed to wrap IPv6 addresses in square brackets before adding a
port number to the end.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) May 14, 2025 14:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 14, 2025
@vllm-bot vllm-bot merged commit a8f5aec into vllm-project:main May 15, 2025
71 of 75 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants