Skip to content

[CI] Fix race condition in test_kv_cache_events test #18169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

[CI] Fix race condition in test_kv_cache_events test #18169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/v1/engine/test_engine_core_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ def test_kv_cache_events(
log_stats=False,
)
endpoint = publisher_config.endpoint.replace("*", "127.0.0.1")
time.sleep(0.1)
subscriber = MockSubscriber(endpoint,
topic=publisher_config.topic,
decode_type=KVEventBatch)
Expand Down
2 changes: 1 addition & 1 deletion vllm/distributed/kv_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def __init__(
self._endpoint = endpoint
self._replay_endpoint = replay_endpoint
self._hwm = hwm
self._socket_setup()

# Payload
self._seq_gen = count()
Expand Down Expand Up @@ -207,7 +208,6 @@ def _socket_setup(self) -> None:
def _publisher_thread(self) -> None:
"""Background thread that processes the event queue."""
self._pack = msgspec.msgpack.Encoder()
self._socket_setup()

assert self._pub is not None # narrows type for mypy

Expand Down