Skip to content

[V1][P/D] Release nixl xfer handles #18204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[V1][P/D] Release nixl xfer handles #18204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07438cf
release nixl xfer handles
ptarasiewiczNV May 15, 2025
3641f98
fix transfer status condition
ptarasiewiczNV May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,10 +622,8 @@ def _pop_done_transfers(self, transfers: dict[str, list[int]]) -> set[str]:
for handle in handles:
xfer_state = self.nixl_wrapper.check_xfer_state(handle)
if xfer_state == "DONE":
# TODO ptarasiewicz: why abort is throwing errors?
# self.nixl_wrapper.release_xfer_handle(handle)
continue
if xfer_state == "PROC":
self.nixl_wrapper.release_xfer_handle(handle)
elif xfer_state == "PROC":
running_reqs.append(handle)
else:
raise RuntimeError("Transfer failed with state %s",
Expand Down