Skip to content

[doc] update reasoning doc #18306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

[doc] update reasoning doc #18306

merged 2 commits into from
May 18, 2025

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented May 17, 2025 •
edited by github-actions bot
Loading

Since PR #14428 updated, so try to update the reasoning_outputs.md.

  • link changed

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 17, 2025
@reidliu41
Copy link
Contributor Author

cc @DarkLight1337

@DarkLight1337 DarkLight1337 requested a review from aarnphm May 17, 2025 14:45
aarnphm
aarnphm requested changes May 17, 2025
View reviewed changes
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

docs/source/features/reasoning_outputs.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this into vllm/reasoning/deepseek_r1_reasoning_parser.py instead?

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, updated, PTAL

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change L291, Please keep the example here.

@reidliu41
[doc] update reasoning doc
b9e2bf7 
Signed-off-by: reidliu41 <reid201711@gmail.com>
@reidliu41 reidliu41 force-pushed the update-reasoning-doc branch from 73afe29 to b9e2bf7 Compare May 18, 2025 00:32
@reidliu41
roll back the example
7579695 
Signed-off-by: reidliu41 <reid201711@gmail.com>
aarnphm
aarnphm approved these changes May 18, 2025
View reviewed changes
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. cc @DarkLight1337

@vllm-bot vllm-bot merged commit 1a8f68b into vllm-project:main May 18, 2025
12 of 14 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@reidliu41
[doc] update reasoning doc (vllm-project#18306)
5444447 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@aarnphm aarnphm aarnphm approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@reidliu41 @jeejeelee @aarnphm @DarkLight1337 @vllm-bot