Skip to content

Conversation

@googs1025
Copy link
Contributor

@googs1025 googs1025 commented May 18, 2025

  • Specify appropriate type parameters for CLI arguments including:
    --tensorizer-uri, --encryption-keyfile, --num-readers,
    --s3-access-key-id, --s3-secret-access-key, and --s3-endpoint.

FIX None

Signed-off-by: googs1025 <googs1025@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@googs1025
Copy link
Contributor Author

@mgoin @simon-mo friendly ping
can you help me this 😄

@simon-mo simon-mo merged commit 275c5da into vllm-project:main May 19, 2025
11 of 13 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants