Skip to content

Conversation

@lifuhuang
Copy link
Contributor

@lifuhuang lifuhuang commented May 18, 2025

The current Phi4mm implementation only supports pixels as input but not embeddings.

The existing embedding handling logic code seems to mistakenly copied from other models -- it's referring to modules not existing in phi4mm self.visual (in phi4mm, the encoding module is vision_encoder)

if image_input["type"] == "image_embeds":
            image_embeds = image_input["image_embeds"].type(self.visual.dtype)

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Lifu Huang <lifu.hlf@gmail.com>
@Isotr0py Isotr0py enabled auto-merge (squash) May 18, 2025 06:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 18, 2025
@vllm-bot vllm-bot merged commit 4fb349f into vllm-project:main May 18, 2025
72 of 74 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Lifu Huang <lifu.hlf@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants