Skip to content

[Build] Supports CUDA 12.6 and 11.8 after Blackwell Update #18316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

[Build] Supports CUDA 12.6 and 11.8 after Blackwell Update #18316

merged 2 commits into from
May 19, 2025

Conversation

@simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented May 18, 2025 •
edited by github-actions bot
Loading

#18095 broke CUDA 12.6 and 11.8 wheel build

@simon-mo
[Build] Supports CUDA 12.6 and 11.8 after Blackwell Update
037cf64 
Signed-off-by: simon-mo <simon.mo@hey.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 18, 2025
@simon-mo
Copy link
Collaborator Author

Test build here https://buildkite.com/vllm/release/builds/5164/steps

@simon-mo
Copy link
Collaborator Author

11.8 failing fixes from #17679

This PR fixed 12.6 build.

@simon-mo
fix if-else
3b98d6b 
Signed-off-by: simon-mo <simon.mo@hey.com>
@simon-mo
Copy link
Collaborator Author

simon-mo commented May 19, 2025 •
edited
Loading

Image built successfully! https://buildkite.com/vllm/release/builds/5166/steps?sid=0196e226-6d79-4d92-82a7-4df7fd3db8a9

@simon-mo simon-mo merged commit 47fda6d into vllm-project:main May 19, 2025
13 of 14 checks passed
markmc added a commit to markmc/vllm that referenced this pull request May 21, 2025
@markmc
Revert "[Build] Supports CUDA 12.6 and 11.8 after Blackwell Update (v…
79faffb 
…llm-project#18316)"

This reverts commit 47fda6d.

Signed-off-by: Mark McLouglin <markmc@redhat.com>
@markmc markmc mentioned this pull request May 21, 2025
Closed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@simon-mo
[Build] Supports CUDA 12.6 and 11.8 after Blackwell Update (vllm-proj…
cf81f1f 
…ect#18316)

Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ci/build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simon-mo @mgoin