Skip to content

Conversation

@heheda12345
Copy link
Collaborator

Add a special KVCacheNullBlock class with ref_cnt always equals 1, so that we can simplify the check that a block is free from block.ref_cnt == 0 and block != self.null_block to block.ref_cnt == 0.

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 24, 2025
@markmc
Copy link
Member

markmc commented May 26, 2025

To fix the entrypoints test failure, rebase to pick up #18543

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed offline, I'd prefer adding is_null attribute to KVCacheBlock and explicitly checking it.
Maybe we can add an assert to the free method, so that we know when the null block is freed.

@heheda12345
Copy link
Collaborator Author

redo in #19031

@heheda12345 heheda12345 closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants