-
-
Couldn't load subscription status.
- Fork 10.8k
[v1] Re-init input batch for multiple kv cache groups #18654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
This pull request has merge conflicts that must be resolved before it can be |
…_batch Signed-off-by: Chen Zhang <zhangch99@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com>
…ject#990) ### What this PR does / why we need it? - Re-enable sleep mode test - Fix nightly performance benchmark workflow - Fix model-runner-v1 bug for upstream [change](vllm-project/vllm#18654) --------- Signed-off-by: wangli <wangli858794774@gmail.com>
Ideally, we should initialize the input batch inside
initialize_kv_cachebased on the kv cache config. However, as in #18298, due to some unknown reasons, we have to initialize the input batch beforeload_model, quantization + weight offloading will fail otherwise.As a temporary solution, we initialize the input batch in
GPUModelRunner.__init__, and re-initialize it ininitialize_kv_cacheonly when necessary.To avoid the error in weight offloading + quantization, we only allow the re-initialization when weight offloading is disabled. This is fine as there is only one kv cache group now, and after hybrid allocator is landed, we can disable hybrid allocator and ensure there is only one kv cache group in this case.