- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.9k
[CI] improve embed testing #18747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] improve embed testing #18747
Conversation
| 👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run  Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add  🚀 | 
| found a serious bug related to nomic context extension. because we did not use the nomic context extension method. For nomic-ai/nomic-embed-text-v1, input length greater than 2048 will result nan, we need fix it | 
| INFO 05-27 15:16:02 [llm_engine.py:230] Initializing a V0 LLM engine (v0.1.dev6754+g27bebcd.d20250527) with config: model='/home/noooop/.cache/huggingface/hub/nomic-embed-text-v2-moe/', speculative_config=None, tokenizer='/home/noooop/.cache/huggingface/hub/nomic-embed-text-v2-moe/' .... max_seq_len=512 .... WARNING 05-27 15:16:03 [bert_with_rope.py:541] We did not use the nomic context extension method, current max_model_len is 2048. The context extension uses vllm style rope_theta and rope_scaling. Because initializing config before config_verify, logs might be confusing. | 
| QvQ need this pr to fix models/test_initialization.py::test_can_initialize[NomicBertModel] https://buildkite.com/vllm/ci/builds/20918#0197149b-bcec-4890-960e-4699d62c1daf Here max_model_len is set to the original length, but Nomic context extension is disabled, so it can't be set to the original length. nomic-ai/nomic-embed-text-v2-moe can pass the test | 
Signed-off-by: amit <amit.man@gmail.com>
rel=MTEB_EMBED_TOLis too strong for testing, suggest usingabs=MTEB_EMBED_TOLe.g.
Snowflake/snowflake-arctic-embed-l
Alibaba-NLP/gte-Qwen2-1.5B-instruct
Offline tested all the tests including skiped models