Skip to content

Skip device and quant Pydantic validation to make plugin device work #18843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Skip device and quant Pydantic validation to make plugin device work #18843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d98edcd
Skip device validation to make plugin device work
Yikun May 28, 2025
47e83f2
Skip quantization validation
Yikun May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vllm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ class ModelConfig:
- 25.6k -> 25,600"""
spec_target_max_model_len: Optional[int] = None
"""Specify the maximum length for spec decoding draft models."""
quantization: Optional[QuantizationMethods] = None
quantization: SkipValidation[Optional[QuantizationMethods]] = None
"""Method used to quantize the weights. If `None`, we first check the
`quantization_config` attribute in the model config file. If that is
`None`, we assume the model weights are not quantized and use `dtype` to
Expand Down Expand Up @@ -2231,7 +2231,7 @@ def is_multi_step(self) -> bool:
class DeviceConfig:
"""Configuration for the device to use for vLLM execution."""

device: Union[Device, torch.device] = "auto"
device: SkipValidation[Union[Device, torch.device]] = "auto"
"""Device type for vLLM execution.
This parameter is deprecated and will be
removed in a future release.
Expand Down