Skip to content

Conversation

noooop
Copy link
Collaborator

@noooop noooop commented Jun 3, 2025

Convert the embedding output to float32, otherwise precision will be lost significantly

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@noooop
Copy link
Collaborator Author

noooop commented Jun 4, 2025

@DarkLight1337

I tested 46 models (including skipped model) participating in ci test_embed_models_mteb.

Among them, 45 could pass the test using auto dtype strategy.

BAAI/bge-code-v1 must use float32 to pass the test. Using hybrid dtype also cannot pass the test.

So we don't need to use hybrid dtype.

Can we merge this pr first.

Identify which step reduced precision when we refactored the pooler and PoolingOutput.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 4, 2025 06:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 4, 2025
@noooop
Copy link
Collaborator Author

noooop commented Jun 4, 2025

@DarkLight1337

tpu-v1-test hanging

#19115

We definitely won't wait for it to end automatically

please manually close and release the CI resources

@DarkLight1337 DarkLight1337 merged commit 35cf32d into vllm-project:main Jun 4, 2025
79 checks passed
@noooop noooop deleted the fix_pooling branch July 10, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants