-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Improve the output precision of embedding models #19092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
I tested 46 models (including skipped model) participating in ci test_embed_models_mteb. Among them, 45 could pass the test using auto dtype strategy. BAAI/bge-code-v1 must use float32 to pass the test. Using hybrid dtype also cannot pass the test. So we don't need to use hybrid dtype. Can we merge this pr first. Identify which step reduced precision when we refactored the pooler and PoolingOutput. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks!
tpu-v1-test hanging We definitely won't wait for it to end automatically please manually close and release the CI resources |
Convert the embedding output to float32, otherwise precision will be lost significantly