Skip to content

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Jun 10, 2025

This PR moves a few log lines onto debug mode

INFO 06-10 17:32:33 [cli_args.py:309] non-default args: ...
INFO 06-10 17:32:38 [config.py:1946] Defaulting to use mp for distributed inference
INFO 06-10 17:32:39 [config.py:536] Overriding HF config with ...

Signed-off-by: Aaron Pham contact@aarnphm.xyz

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@aarnphm aarnphm enabled auto-merge (squash) June 10, 2025 17:51
@aarnphm aarnphm requested a review from hmellor June 10, 2025 17:51
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @aarnphm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to clean up the initial console output by changing the severity level of a few startup-related log messages. By moving these messages from INFO to DEBUG, they will only appear when logging is configured to a more verbose level, resulting in a less cluttered default experience.

Highlights

  • Logging Verbosity: Downgraded several initial log messages from INFO to DEBUG level to reduce default output noise.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 10, 2025
@aarnphm aarnphm requested a review from DarkLight1337 June 10, 2025 17:51
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully moves several initial log messages from INFO to DEBUG level, effectively reducing the default log verbosity as intended. The changes are straightforward and correctly implemented. The primary feedback relates to the trade-off between reduced log noise and the potential impact on debuggability for certain initial configuration details, particularly the non-default CLI arguments.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change but would like others to take a look as well

@aarnphm aarnphm requested a review from DarkLight1337 June 19, 2025 18:14
@russellb russellb disabled auto-merge June 19, 2025 19:05
@russellb russellb enabled auto-merge (squash) June 19, 2025 19:05
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm force-pushed the chore/debloat-loading-logs branch from 1ad640d to 2c92359 Compare June 25, 2025 02:45
@russellb russellb merged commit ba7ba35 into vllm-project:main Jun 25, 2025
68 checks passed
@aarnphm aarnphm deleted the chore/debloat-loading-logs branch June 25, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants