Skip to content

[ROCm][V1] Adding ROCm to the list of plaforms using V1 by default #19440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

[ROCm][V1] Adding ROCm to the list of plaforms using V1 by default #19440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f62f3ec
Adding ROCm to the list of plaforms using V1 by default
gshtras Jun 9, 2025
851dedf
Merge remote-tracking branch 'origin/main' into rocm_default_v1
gshtras Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,7 @@ def _is_v1_supported_oracle(self, model_config: ModelConfig) -> bool:

# Non-[CUDA, TPU] may be supported on V1, but off by default for now.
v0_hardware = not any(
(current_platform.is_cuda(), current_platform.is_tpu(),
(current_platform.is_cuda_alike(), current_platform.is_tpu(),
(current_platform.is_cpu()
and current_platform.get_cpu_architecture() == CpuArchEnum.X86)))
if v0_hardware and _warn_or_fallback( # noqa: SIM103
Expand Down