-
-
Notifications
You must be signed in to change notification settings - Fork 11k
use base version for version comparison #19587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use base version for version comparison #19587
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
9f864d0 to
dc79178
Compare
Signed-off-by: Boyuan Feng <boyuan@meta.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com>
ec866e7 to
7a4723c
Compare
|
cc @drisspg @jerryzh168, turns out standalone_compile was not enabled by default for nightlies yet. The flag VLLM_USE_STANDALONE_COMPILE=1 still works for testing. |
| if compilation_config.use_inductor: | ||
| if envs.VLLM_USE_STANDALONE_COMPILE and is_torch_equal_or_newer( | ||
| "2.8.0"): | ||
| "2.8.0a"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what does "a" in "2.8.0a" mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'a' is a standard version for alpha: https://peps.python.org/pep-0440/
current pytorch nightly has the version 2.8.0a0+git093fd47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for the explanation. So the version parser thinks 2.8.0 > 2.8.0a then.
#18846 turns standalone_compile on by default via
is_torch_equal_or_newer("2.8.0"). One major motivation is to use standalone_compile for vllm x torch nightly CI tests.However, it has no effect yet. The current torch nightly gives

2.8.0a0+...which is a pre-release and is considered to be less than2.8.0. This PR fixes the issue by comparing with2.8.0a.