[CI][CPU] Improve dummy Triton interfaces and fix the CPU CI #19838
Conversation
Signed-off-by: jiang1.li <jiang1.li@intel.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @bigPYJ1151, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to enhance the system's resilience in CPU environments where the Triton library might not be installed, and to resolve related continuous integration failures. It achieves this by making the dummy Triton interface more comprehensive and by adjusting CPU-specific dependency requirements to facilitate smoother CI runs.
Highlights
- Dummy Triton Interface Enhancement: The
TritonPlaceholderclass, which serves as a mock for the Triton library when it's not installed, has been improved. It now includes dummy implementations for the__version__attribute (set to "3.1.0") and aConfigattribute, making it more robust and preventing potential attribute errors in environments where Triton is not present. - CPU CI Fixes and Dependency Management: The
requirements/cpu.txtfile was updated to remove the explicittriton==3.2.0dependency for x86_64 CPU builds. This change directly addresses issues with the CPU CI, likely by allowing the build process to proceed without a strict Triton installation, relying instead on the improvedTritonPlaceholder.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to improve the dummy Triton interfaces and fix CPU CI tests. Key changes include:
requirements/cpu.txt: Removed the pinnedtriton==3.2.0dependency for x86_64 CPUs. This is a positive change if the improvedTritonPlaceholdernow adequately handles scenarios where Triton is absent on CPU, making an actual (even old) Triton installation unnecessary for CI.vllm/triton_utils/importing.py:- Added
__version__ = "3.1.0"toTritonPlaceholder. This is a good addition, making the placeholder more closely mimic the real Triton module. - Added a dummy
self.Configattribute. The current implementation using_dummy_decoratormakestriton.Config(...)return a lambda. I've suggested an improvement to return atypes.SimpleNamespaceinstance to make the dummyConfigmore robust (see specific comment).
- Added
The PR description checklist indicates that the test plan and test results are not yet provided. It would be beneficial to include these, especially to confirm that the CPU CI issues are resolved and to demonstrate the behavior of the improved dummy interfaces. Consider adding specific tests for the new __version__ attribute and the behavior of the dummy triton.Config in tests/test_triton_utils.py to ensure the placeholder works as expected.
| self.jit = self._dummy_decorator("jit") | ||
| self.autotune = self._dummy_decorator("autotune") | ||
| self.heuristics = self._dummy_decorator("heuristics") | ||
| self.Config = self._dummy_decorator("Config") |
There was a problem hiding this comment.
The current implementation of the dummy triton.Config using _dummy_decorator results in triton.Config(...) returning a lambda function (lambda f: f). While this prevents an AttributeError when triton.Config is called, it can lead to issues if the code attempts to access attributes on the instance returned by triton.Config(...) (e.g., my_config.num_warps).
For a more robust placeholder that better mimics the behavior of triton.Config (which is a class that creates config objects), consider returning an object that can hold attributes. types.SimpleNamespace is a good candidate for this.
This change would make the TritonPlaceholder more generally useful and less likely to cause unexpected errors when Triton is not installed.
| self.Config = self._dummy_decorator("Config") | |
| self.Config = lambda defines_arg=None, **kwargs: types.SimpleNamespace(defines=defines_arg if defines_arg is not None else {}, **kwargs) |
Signed-off-by: jiang1.li <jiang1.li@intel.com>
…oject#19838) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: juncheoll <th6re8e@naver.com>
2 participants
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
TritonPlaceholderby adding__version__andConfigTest Plan
Test Result
(Optional) Documentation Update