-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Misc] Clean up useless code #19889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Clean up useless code #19889
Conversation
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @wangxiyuan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a targeted code hygiene effort, removing an identified section of unreachable code from vllm/config.py
. The change specifically targets a conditional block that would never execute, thereby improving the codebase's clarity and maintainability without introducing any functional changes or altering existing behavior.
Highlights
- Code Cleanup: Removed a block of dead code in
vllm/config.py
within the__post_init__
method. This code was part of a conditional check forray_only_devices
that would never evaluate to true, rendering the associated logic unreachable.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a block of dead code from the ParallelConfig.__post_init__
method in vllm/config.py
.
The removed code initialized a list ray_only_devices
as empty and then checked if current_platform.device_type
was present in this empty list. Since this condition would always be false, the subsequent logic to set self.distributed_executor_backend
to "ray" or raise a ValueError
was unreachable.
The removal is correct and improves code clarity and maintainability by eliminating this unused logic. The local import of current_platform
within the removed block was also redundant, as current_platform
is already imported at the module level and available in the __post_init__
scope.
This change is a good cleanup and has no impact on existing functionality.
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: juncheoll <th6re8e@naver.com>
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: fhl <2410591650@qq.com>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Clean up the useless code in config.py
Test Plan
Just a code clean up, no need for test update
Test Result
(Optional) Documentation Update