-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[Bugfix] Fix Gemma3 weights loading #20029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides a critical bugfix for Gemma3 model weight loading. It resolves an issue where unquantized Gemma3 models failed to load due to a misconfigured name mapping for the vision component, ensuring that these models can now be successfully initialized and used.
Highlights
- Bugfix: Corrected a regression introduced in PR #19643 that prevented the proper loading of unquantized Gemma3 model weights. The issue stemmed from an incorrect name mapping for the
vision_modelcomponent. - Model Loading: Adjusted the
_get_name_mappinglogic within theGemma3ForConditionalGenerationclass to correctly handle thevision_model.vision_model.mapping, specifically forllm-compressorquantized checkpoints.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a bug in Gemma3 weights loading by correcting the name mapping for llm-compressor quantized checkpoints. The changes involve moving the orig_to_new_substr mapping into its own dictionary within the hf_to_vllm_mapper in Gemma3ForConditionalGeneration. This ensures that the mapping for quantized checkpoints is correctly applied. The code is more readable and the fix addresses the weights loading issue.
| }, | ||
| orig_to_new_substr={ | ||
| # mapping for llm-compressor quantized checkpoints | ||
| "vision_model.vision_model.": "vision_model.", | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the orig_to_new_substr mapping into its own dictionary improves readability and organization. This change also ensures that the mapping for quantized checkpoints is correctly applied, fixing the weights loading issue. However, it would be more readable if the orig_to_new_substr dictionary was defined before the orig_to_new_prefix dictionary.
orig_to_new_substr={
# mapping for llm-compressor quantized checkpoints
"vision_model.vision_model.": "vision_model.",
},
orig_to_new_prefix={
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
vision_model.vision_model.exactly, my bad! 😢Test Plan
Test Result
(Optional) Documentation Update