Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Jun 24, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

python examples/offline_inference/vision_language.py -m gemma3

Test Result

  • Gemma3 loading should work now.

(Optional) Documentation Update

Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a critical bugfix for Gemma3 model weight loading. It resolves an issue where unquantized Gemma3 models failed to load due to a misconfigured name mapping for the vision component, ensuring that these models can now be successfully initialized and used.

Highlights

  • Bugfix: Corrected a regression introduced in PR #19643 that prevented the proper loading of unquantized Gemma3 model weights. The issue stemmed from an incorrect name mapping for the vision_model component.
  • Model Loading: Adjusted the _get_name_mapping logic within the Gemma3ForConditionalGeneration class to correctly handle the vision_model.vision_model. mapping, specifically for llm-compressor quantized checkpoints.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in Gemma3 weights loading by correcting the name mapping for llm-compressor quantized checkpoints. The changes involve moving the orig_to_new_substr mapping into its own dictionary within the hf_to_vllm_mapper in Gemma3ForConditionalGeneration. This ensures that the mapping for quantized checkpoints is correctly applied. The code is more readable and the fix addresses the weights loading issue.

Comment on lines +482 to +487
},
orig_to_new_substr={
# mapping for llm-compressor quantized checkpoints
"vision_model.vision_model.": "vision_model.",
},
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Moving the orig_to_new_substr mapping into its own dictionary improves readability and organization. This change also ensures that the mapping for quantized checkpoints is correctly applied, fixing the weights loading issue. However, it would be more readable if the orig_to_new_substr dictionary was defined before the orig_to_new_prefix dictionary.

        orig_to_new_substr={
            # mapping for llm-compressor quantized checkpoints
            "vision_model.vision_model.": "vision_model.",
        },
        orig_to_new_prefix={

@Isotr0py Isotr0py closed this Jun 24, 2025
@Isotr0py Isotr0py deleted the fix-gemma3 branch June 24, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VLLM serve VLM quantized Gemma3 KeyError: 'vision_model.encoder.layers.0.self_attn.qkv_proj.weight'

1 participant