Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Jun 26, 2025

Purpose

FIX #20148

The models/test_oot_registration.py::test_oot_registration_embedding test seems to be failing in CI consistently with a context length OOM

https://buildkite.com/vllm/ci/builds/22737/steps/canvas?sid=0197acae-970a-43ee-9fef-108d8a58da0c#0197acae-98db-423d-8af9-eb4eb401f1b4/212-1320

[2025-06-26T16:27:15Z] ERROR 06-26 09:27:15 [core.py:519] ValueError: To serve at least one request with the models's max seq len (8192), (2.63 GiB KV cache is needed, which is larger than the available KV cache memory (1.64 GiB). Based on the available memory, the estimated maximum model length is 5088. Try increasing `gpu_memory_utilization` or decreasing `max_model_len` when initializing the engine.

Test Plan

Green CI for this test

Test Result

https://buildkite.com/vllm/fastcheck/builds/28504/steps/canvas?jid=0197ad94-571b-474d-9172-cb63c661f112

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin added the bug Something isn't working label Jun 26, 2025
@mgoin mgoin added the ci-failure Issue about an unexpected test failure in CI label Jun 26, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mgoin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve a recurring Out-Of-Memory (OOM) issue observed in CI for a specific embedding test. By constraining the maximum model length used within the test, it prevents excessive memory consumption, thereby improving the reliability and stability of the CI pipeline for this test case.

Highlights

  • Test Stability: Addressed a consistent Out-Of-Memory (OOM) error in the test_oot_registration_embedding test by explicitly setting a reduced max_model_len during LLM initialization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses an out-of-memory (OOM) error in the test_oot_registration_embedding test by explicitly setting max_model_len to 2048. This is a direct and appropriate fix for the issue observed in CI, as it reduces the memory required for the KV cache. The change is localized to the failing test and appears correct. I have no further suggestions.

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 26, 2025
@mgoin mgoin changed the title Fix OOM with test_oot_registration_embedding [CI Failure] Fix OOM with test_oot_registration_embedding Jun 26, 2025
@Isotr0py Isotr0py merged commit 71799fd into vllm-project:main Jun 27, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[CI Failure]: Plugin Tests (2 GPUs) - models/test_oot_registration.py

3 participants