fix import error on rocm #20346
fix import error on rocm #20346
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @842974287, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves an ImportError that was preventing the application from running correctly on ROCm due to missing FlashAttention utilities. By conditionally setting references to these utilities to None when they are not importable, the system can now gracefully handle environments where these specific functions are absent, ensuring broader compatibility.
Highlights
- Error Handling & ROCm Compatibility: Introduced an
elseblock to explicitly set FlashAttention-related function references (reshape_and_cache_flash,flash_attn_varlen_func,get_scheduler_metadata) toNone. This change addresses anImportErrorthat occurs when these functions cannot be imported, particularly in environments like ROCm where they might not be available.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
This pull request was exported from Phabricator. Differential Revision: D77632282 |
vllm/attention/utils/fa_utils.py
Outdated
There was a problem hiding this comment.
This line contains trailing whitespace and adds an extra blank line. This results in three blank lines before the next function definition, whereas PEP 8 style guidelines recommend two. Please remove this line to improve code cleanliness and maintain consistency with the project's coding style.
|
Please fix pre-commit |
Summary: Fixing "ImportError: cannot import name 'flash_attn_varlen_func' from 'vllm.attention.utils.fa_utils'". Reviewed By: houseroad Differential Revision: D77632282
842974287
force-pushed
the
export-D77632282
branch
from
057953d to
aa25acc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77632282 |
|
Fixed by #20143 already |
4 participants
Summary: Fixing "ImportError: cannot import name 'flash_attn_varlen_func' from 'vllm.attention.utils.fa_utils'".
Differential Revision: D77632282