-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Add ignore consolidated file in mistral example code #20420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…er use Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @princepride, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an efficiency issue in the vLLM example code for Mistral-3 models by ensuring that a large, unused model weights file is no longer downloaded. By specifying an ignore pattern during model initialization, the examples now operate with a reduced footprint, improving the initial setup experience for users.
Highlights
- Resource Optimization: I've added a configuration to prevent the download of the
consolidated.safetensorsfile for Mistral-3 models in the example code. This file, approximately 100 GB in size, was being downloaded unnecessarily as it is not used by the example, leading to significant savings in download time and disk space.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses a significant efficiency issue by preventing the unnecessary download of the large consolidated.safetensors file for the Mistral model in the example scripts. The addition of ignore_patterns=["consolidated.safetensors"] to the EngineArgs constructor in both vision_language.py and vision_language_multi_image.py is a direct and correct solution. The changes are clear, concise, and improve the user experience by reducing download size and time without introducing new complexities or correctness concerns. The test results confirm the successful implementation of this ignore pattern.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
cc @patrickvonplaten do you have any problems with this change? |
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true and fair enough, thanks!
Add ignore consolidated.safetensors file because the weights file never use
Purpose
As #20025 said, now the example code will download the whole weights files (about 100 GB) but the

consolidated.safetensorsweights file is never used.Test Plan
python examples/offline_inference/vision_language.py -m mistral3Test Result