-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Implement OpenAI Responses API [1/N] #20504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @WoosukKwon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new OpenAI-compatible Responses API endpoint to the vLLM server. It involves defining new request and response protocols, implementing the core serving logic for this API, and integrating it into the existing API server. The aim is to support more structured and advanced model interactions, potentially including features like tool use and reasoning extraction, beyond standard chat completions.
Highlights
- New API Endpoint: Introduced a new
/v1/responsesAPI endpoint, aligning with the OpenAI Responses API specification. This endpoint allows for more structured and potentially advanced interactions with the model. - Protocol Definition: Defined new
ResponsesRequestandResponsesResponsePydantic models invllm/entrypoints/openai/protocol.pyto handle the specific request and response formats for the new Responses API, including support for various parameters likebackground,include,input,instructions,tools, andreasoning. - Core Serving Logic: Added a new
OpenAIServingResponsesclass invllm/entrypoints/openai/serving_responses.py(a new file) to encapsulate the business logic for the Responses API. This includes handling prompt preprocessing, scheduling requests with the engine, processing model outputs, and formatting the final response, including support for reasoning content extraction. - Input Handling Enhancement: Modified
vllm/entrypoints/chat_utils.pyto recognize and processinput_textcontent parts, ensuring compatibility and proper handling of text inputs within the new Responses API context. - API Server Integration: Integrated the new Responses API service into
vllm/entrypoints/openai/api_server.pyby importing necessary components, adding a new FastAPI route for/v1/responses, and initializing theOpenAIServingResponsesinstance within the application state.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the OpenAI Responses API. The changes include adding a new endpoint, protocol definitions, and a serving class for this new API. The implementation looks like a good start, but there are a few issues to address. I've found a bug related to a duplicated argument, a correctness issue with guided decoding schema handling, and some areas for improvement in request object mutation and background task management. I've also pointed out a leftover debug print statement that should be removed.
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
|
Hi ! It would be great to update the docs here about the Responses API support : https://docs.vllm.ai/en/latest/serving/openai_compatible_server.html 🙏 |
This PR implements the basic support for the OpenAI Responses API.
TODOs: