Skip to content

Conversation

@crypdick
Copy link
Contributor

@crypdick crypdick commented Jul 7, 2025

Purpose

Improve documentation for RLHF example
(Decomposing #20040 into multiple PRs)

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @crypdick, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I have reviewed this pull request, which focuses entirely on enhancing the documentation within the examples/offline_inference/rlhf.py file. The primary goal is to provide a clearer and more comprehensive understanding of the RLHF example's architecture, its operational steps, and the underlying Ray and GPU resource management, making the code more accessible and understandable for users.

Highlights

  • Improved Module Docstring: The main docstring of rlhf.py has been significantly expanded and rewritten to offer a detailed explanation of the RLHF demonstration, including its use of vLLM and Ray, GPU allocation, and a step-by-step breakdown of the example's execution flow.
  • Enhanced Code Comments: Numerous inline comments throughout the file have been updated for improved clarity, conciseness, and informational value. This includes better explanations for the MyLLM class, Ray placement group setup, vLLM engine initialization, and the simulated training and weight synchronization processes.
  • Clarified GPU and Ray Integration: The documentation now explicitly details how GPUs are utilized (GPU 0 for training, GPUs 1-2 for vLLM inference) and how Ray is leveraged for process placement and inter-process communication, providing crucial context for understanding the example's distributed nature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the documentation for the RLHF example by rewriting the main docstring and clarifying comments throughout the script. The changes make the example easier to understand.

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one nit about MD formatting

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@vllm-bot vllm-bot merged commit 235bfd5 into vllm-project:main Jul 15, 2025
13 checks passed
@crypdick crypdick deleted the docs/rlhf branch July 15, 2025 22:43
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants