-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Temporarily suspend google/gemma-3-1b-it. #20722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @QiliangCui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request temporarily removes the 'google/gemma-3-1b-it' model from the accuracy tests to address timeout issues and assertion errors encountered during testing. This change aims to unblock the testing process and allow for further investigation of the model's behavior.
Highlights
- Temporary Removal: Temporarily removed 'google/gemma-3-1b-it' from the list of models to unblock testing due to timeout and assertion errors.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request temporarily disables a failing test for the google/gemma-3-1b-it model by commenting it out to unblock testing. My review focuses on improving the maintainability of this temporary change. I've suggested adding TODO comments to provide context for why the test is disabled and to ensure it's re-enabled correctly in the future. This will help other developers understand the state of the tests at a glance.
|
We should only skip this test for TPU, since the regular CI passes |
dfc4587 to
32016fa
Compare
I don't think other CI is using this. If they do, I think it should fail today as well because the assertion of And I as pointed out in the comment, this test was added in the first place because of TPU change. |
9089fb2 to
c22082d
Compare
|
Thanks @QiliangCui for looking into it. Some anecdote, at the time when the pr is merged, the test pass locally but failed in the CI. The failure in that CI was caused by a breaking change and fixed a few days later #16059 What's the current failure in the CI? If it is https://buildkite.com/vllm/ci/builds/23569/steps/canvas?jid=0197f302-6b71-4b36-bb01-9b250a0349b0, ie then the issue seems to be huggingface failed to download the model. If it's the case, then it's likely the issue will recur even we suspend this model. But I'm curious if other vLLM folks have seen the error (huggingface fails to download the model) |
|
According to Buildkite, the test is being run on main CI currently, and passes: https://buildkite.com/organizations/vllm/analytics/suites/ci-1/tests/650bf63b-9929-8ff0-8ddb-791931888d24?period=1day&tags=scm.branch%3Amain |
Right! there are 2 common way it fails today:
Since this is a known blocking issue, I think it is better way disable it for now, make the TPU V1 Test green, investigate the problem and re-enable. I don't thnk leaving it fail is a good. Do you have a better idea? |
Thank you for finding this. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use pytest.skip
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Purpose
Temporally remove the google/gemma-3-1b-it to unblock testing.
Because
AssertionError: Expected: 0.25 | Measured: 0.13191811978771797Test Plan
Test and see result on fast check.
Test Result
The test passes in fastcheck
