[Bugfix][Build][Non-CUDA] Only referencing CMAKE_CUDA_COMPILER_VERSION on CUDA where it is defined #20738
Conversation
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @gshtras, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides a critical bug fix addressing a build regression that affected non-CUDA environments. The change ensures that the build system correctly handles the absence of CUDA-specific variables, allowing for successful compilation on all intended platforms.
Highlights
- Build Fix: Reordered a conditional check in
CMakeLists.txtto ensureCMAKE_CUDA_COMPILER_VERSIONis only evaluated whenVLLM_GPU_LANGis explicitly set to "CUDA". This prevents build failures on non-CUDA platforms whereCMAKE_CUDA_COMPILER_VERSIONwould otherwise be undefined.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
This pull request addresses a build regression for non-CUDA environments. The root cause was the evaluation of CMAKE_CUDA_COMPILER_VERSION, which is undefined in non-CUDA builds, leading to a CMake error.
The proposed fix correctly introduces a nested conditional check. It first verifies if the build is for CUDA (VLLM_GPU_LANG STREQUAL "CUDA") before attempting to check the compiler version. This is the idiomatic and safe way to handle such conditional logic in CMake, preventing the parser from evaluating an expression with an undefined variable.
The change is correct, minimal, and effectively resolves the build failure. I have no further comments.
github-actions
bot
added
the
ready
…N on CUDA where it is defined (vllm-project#20738) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…N on CUDA where it is defined (vllm-project#20738) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…N on CUDA where it is defined (vllm-project#20738) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…N on CUDA where it is defined (vllm-project#20738) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…N on CUDA where it is defined (vllm-project#20738) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
3 participants
Fix build regression from #20694
Purpose
Fix build on any platform where CMAKE_CUDA_COMPILER_VERSION is not defined