Skip to content

[Model] Remove model sampler #21059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

[Model] Remove model sampler #21059

merged 1 commit into from
Jul 16, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 16, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

These methods are redundant since #17084

Test Plan

Test Result

(Optional) Documentation Update

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 16, 2025
@DarkLight1337 DarkLight1337 changed the title Remove model sampler [Model] Remove model sampler Jul 16, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the qwen Related to Qwen models label Jul 16, 2025
@DarkLight1337 DarkLight1337 force-pushed the remove-model-sampler branch from 22a7f8c to ea82428 Compare July 16, 2025 15:11
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the model sampler and unifies the pooling model interface. I've identified a critical syntax error and a couple of high-severity logical issues in the new Pooler implementation that should be addressed.

@DarkLight1337
[Model] Remove unused sample methods
5d5d6f1 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 force-pushed the remove-model-sampler branch from ea82428 to 5d5d6f1 Compare July 16, 2025 15:14
@DarkLight1337 DarkLight1337 removed the qwen Related to Qwen models label Jul 16, 2025
Isotr0py
Isotr0py approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 16, 2025 15:51
@DarkLight1337 DarkLight1337 merged commit ac2bf41 into vllm-project:main Jul 16, 2025
70 checks passed
@DarkLight1337 DarkLight1337 deleted the remove-model-sampler branch July 16, 2025 19:03
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@DarkLight1337 @x22x22
[Model] Remove model sampler (vllm-project#21059)
6a65eb5 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@DarkLight1337
[Model] Remove model sampler (vllm-project#21059)
54e2977 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@DarkLight1337 @npanpaliya
[Model] Remove model sampler (vllm-project#21059)
7b27150 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@DarkLight1337 @jinzhen-lin
[Model] Remove model sampler (vllm-project#21059)
0395886 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@DarkLight1337 @paulpak58
[Model] Remove model sampler (vllm-project#21059)
859b125 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@DarkLight1337 @diegocastanibm
[Model] Remove model sampler (vllm-project#21059)
482a388 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
@DarkLight1337 @epwalsh
[Model] Remove model sampler (vllm-project#21059)
0049f72 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarkLight1337 @Isotr0py