-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Feature][eplb] add verify ep or tp or dp #21102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds validation checks for Expert Parallelism Load Balancing (EPLB) configuration. The checks ensure that when EPLB is enabled, expert parallelism is also enabled, and both tensor and data parallelism are configured with more than one worker. I suggested improving the clarity of the validation error messages to provide more specific guidance to the user.
41b5e9a to
70d081c
Compare
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
70d081c to
9a974da
Compare
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
9a974da to
f7dc281
Compare
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: qizixi <qizixi@meta.com>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: x22x22 <wadeking@qq.com>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Because if not use tp or dp or ep, so enable eplb whether meaningful.
Purpose
Test Plan
Test Result
(Optional) Documentation Update