Skip to content

Conversation

@lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Jul 17, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)". [Feature]: Add Enable EPLB condition #20669
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Because if not use tp or dp or ep, so enable eplb whether meaningful.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds validation checks for Expert Parallelism Load Balancing (EPLB) configuration. The checks ensure that when EPLB is enabled, expert parallelism is also enabled, and both tensor and data parallelism are configured with more than one worker. I suggested improving the clarity of the validation error messages to provide more specific guidance to the user.

@lengrongfu lengrongfu force-pushed the feat/add-eplb-validate branch from 41b5e9a to 70d081c Compare July 17, 2025 07:55
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@lengrongfu lengrongfu changed the title [misc][eplb] add valida ep or tp or dp [misc][eplb] add verify ep or tp or dp Jul 20, 2025
@lengrongfu lengrongfu changed the title [misc][eplb] add verify ep or tp or dp [Feature][eplb] add verify ep or tp or dp Jul 21, 2025
@lengrongfu lengrongfu force-pushed the feat/add-eplb-validate branch from 70d081c to 9a974da Compare July 21, 2025 11:08
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
@lengrongfu lengrongfu force-pushed the feat/add-eplb-validate branch from 9a974da to f7dc281 Compare July 21, 2025 12:14
@hmellor hmellor enabled auto-merge (squash) July 21, 2025 15:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 21, 2025
@vllm-bot vllm-bot merged commit 3779eb8 into vllm-project:main Jul 22, 2025
70 of 75 checks passed
zixi-qi pushed a commit to zixi-qi/vllm that referenced this pull request Jul 23, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: qizixi <qizixi@meta.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants