Skip to content

Conversation

@LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Jul 18, 2025

Temp fix to avoid potential error with TorchSDPABackendImpl not saving iRoPE; preferred fix is: #21188 but putting this up this simple fix incase that doesnt make it in time for the cut

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Jul 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a temporary fix for a potential AttributeError when accessing use_irope on an attention implementation. The change uses getattr to safely access the attribute with a default value, which is a robust and Pythonic approach. The fix is correct and effectively prevents the runtime error as intended. Given the context that this is a temporary solution, the change is appropriate.

@mgoin mgoin enabled auto-merge (squash) July 18, 2025 18:35
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 18, 2025
@LucasWilkinson LucasWilkinson disabled auto-merge July 18, 2025 20:09
@LucasWilkinson
Copy link
Collaborator Author

Holding off the merge for now since this is not needed if #21188 lands

@mgoin mgoin removed this from the v0.10.0 milestone Jul 18, 2025
@vllm-bot vllm-bot merged commit 468e240 into vllm-project:main Jul 19, 2025
74 of 77 checks passed
@DarkLight1337
Copy link
Member

DarkLight1337 commented Jul 19, 2025

Oops sorry I missed this comment, was working from latest to oldest PRs

x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
…lm-project#21200)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
…lm-project#21200)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
…lm-project#21200)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
…lm-project#21200)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…lm-project#21200)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…lm-project#21200)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
…lm-project#21200)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants