-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[BugFix][CPU] Fix TorchSDPABackendImpl doesn't have use_irope
#21200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a temporary fix for a potential AttributeError when accessing use_irope on an attention implementation. The change uses getattr to safely access the attribute with a default value, which is a robust and Pythonic approach. The fix is correct and effectively prevents the runtime error as intended. Given the context that this is a temporary solution, the change is appropriate.
|
Holding off the merge for now since this is not needed if #21188 lands |
|
Oops sorry I missed this comment, was working from latest to oldest PRs |
…lm-project#21200) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: x22x22 <wadeking@qq.com>
…lm-project#21200) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
…lm-project#21200) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
…lm-project#21200) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…lm-project#21200) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…lm-project#21200) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…lm-project#21200) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Temp fix to avoid potential error with
TorchSDPABackendImplnot saving iRoPE; preferred fix is: #21188 but putting this up this simple fix incase that doesnt make it in time for the cut