Skip to content

Conversation

@QiliangCui
Copy link
Contributor

@QiliangCui QiliangCui commented Jul 23, 2025

Purpose

Separate the large test into 2 and give each a shorter timeout.
TODO: merge the common logic to avoid copy paste after test enabled.

Test Plan

Run on CI.

Test Result

Wait for result.

@mergify mergify bot added the ci/build label Jul 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request splits the TPU v1 tests into two parts to manage test execution time. This was achieved by creating a new script for the second part of the tests and removing them from the original script. While this works, it introduces significant code duplication between the two test scripts. I suggest refactoring to improve maintainability.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@khluu
Copy link
Collaborator

khluu commented Jul 23, 2025

LGTM.. pending on vllm-project/ci-infra#128

@mergify
Copy link

mergify bot commented Jul 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @QiliangCui.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 24, 2025
@mergify mergify bot removed the needs-rebase label Jul 24, 2025
@QiliangCui QiliangCui force-pushed the divide-test branch 2 times, most recently from c898c5e to ca04414 Compare July 25, 2025 03:31
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
@QiliangCui
Copy link
Contributor Author

@khluu and @yaochengji , can you help to merge this change?

@khluu khluu enabled auto-merge (squash) July 26, 2025 04:53
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 26, 2025
@khluu khluu merged commit 7728dd7 into vllm-project:main Jul 26, 2025
90 checks passed
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
HsChen-sys pushed a commit to HsChen-sys/vllm that referenced this pull request Aug 1, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants