Skip to content

remove GLM-4 quantization wrong Code #21435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

remove GLM-4 quantization wrong Code #21435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa1351
remove
zRzRzRzRzRzRzR Jul 23, 2025
0f35c3c
1
zRzRzRzRzRzRzR Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/entrypoints/openai/tool_parsers/glm4_moe_tool_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
logger = init_logger(__name__)


@ToolParserManager.register_module("glm4_moe")
@ToolParserManager.register_module("glm45")
class Glm4MoeModelToolParser(ToolParser):

def __init__(self, tokenizer: AnyTokenizer):
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/glm4_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
self.embed_tokens = VocabParallelEmbedding(
config.vocab_size,
config.hidden_size,
quant_config=quant_config,
prefix=f"{prefix}.embed_tokens")
Comment on lines 390 to 393
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change unconditionally removes quant_config from the VocabParallelEmbedding layer, which will disable quantization for token embeddings. While this might be the intended fix for certain quantization methods (e.g., GPTQ, AWQ), it will break support for others that rely on quantizing the embedding layer, such as GGUF.

When quant_config is not provided, VocabParallelEmbedding defaults to UnquantizedEmbeddingMethod. This method does not create the necessary parameters (like qweight) for GGUF, which will lead to failures during weight loading for GGUF-quantized GLM-4.5 models.

This is a critical issue as it silently disables a supported quantization format for this model.

A more robust solution would be to conditionally pass quant_config based on the quantization method. For instance, you could check if quant_config.get_name() == 'gguf' and only pass the config in that case, preserving the fix for other methods while maintaining GGUF compatibility.

else:
self.embed_tokens = PPMissingLayer()
Expand Down
2 changes: 1 addition & 1 deletion vllm/reasoning/glm4_moe_reasoning_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
logger = init_logger(__name__)


@ReasoningParserManager.register_module("glm4_moe")
@ReasoningParserManager.register_module("glm45")
class Glm4MoeModelReasoningParser(ReasoningParser):
"""
Reasoning parser for the Glm4MoeModel model.
Expand Down