Skip to content

Conversation

@minosfuture
Copy link
Contributor

@minosfuture minosfuture commented Jul 25, 2025

Purpose

  • Use dracut for init ramdisk creation on CentOS. (update-initramfs is for Debian)
  • Skip git clone EP kernel repos

Test Plan

run scripts locally

Test Result

scripts work well

(Optional) Documentation Update

Signed-off-by: Ming Yang <minos.future@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves system configuration and installation scripts by using dracut on CentOS and skipping cloning if repos exist. The review focuses on improving the robustness of the repository cloning logic to handle cases of partial or failed clones, which could otherwise cause script failures on subsequent runs. Changes were suggested to ensure the scripts are more resilient.

Signed-off-by: Ming Yang <minos.future@gmail.com>
@simon-mo simon-mo merged commit f12d925 into vllm-project:main Jul 30, 2025
12 of 14 checks passed
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
vadiklyutiy pushed a commit to CentML/vllm that referenced this pull request Aug 5, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: x22x22 <wadeking@qq.com>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
…el installation (vllm-project#21635)

Signed-off-by: Ming Yang <minos.future@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants