-
-
Couldn't load subscription status.
- Fork 10.8k
[Misc] Use dracut on CentOS and skip clone if repo exists for EP kernel installation #21635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ming Yang <minos.future@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves system configuration and installation scripts by using dracut on CentOS and skipping cloning if repos exist. The review focuses on improving the robustness of the repository cloning logic to handle cases of partial or failed clones, which could otherwise cause script failures on subsequent runs. Changes were suggested to ensure the scripts are more resilient.
Signed-off-by: Ming Yang <minos.future@gmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com> Signed-off-by: x22x22 <wadeking@qq.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com>
…el installation (vllm-project#21635) Signed-off-by: Ming Yang <minos.future@gmail.com>
Purpose
Test Plan
run scripts locally
Test Result
scripts work well
(Optional) Documentation Update