Skip to content

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Jul 26, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

fixes: #21614

Test Plan

Test Result

(Optional) Documentation Update

@mergify mergify bot added new-model Requests to new models qwen Related to Qwen models labels Jul 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for loading Qwen3-Embedding models by registering the model and adding logic to handle weight prefixes. I've identified a critical bug in the load_weights implementation that will cause a crash when loading models that already have the correct weight prefix. A fix has been suggested.

Signed-off-by: reidliu41 <reid201711@gmail.com>
@reidliu41 reidliu41 force-pushed the fix-qwen3-embed-load-issue branch from 24d897c to 4481983 Compare July 26, 2025 02:48
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@reidliu41
Copy link
Contributor Author

cc @noooop

@noooop
Copy link
Collaborator

noooop commented Jul 26, 2025

I'm sorry, I think this error is caused by #21227 and should be fixed by #21470.

@reidliu41
Copy link
Contributor Author

ok, got it

@reidliu41 reidliu41 closed this Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-model Requests to new models qwen Related to Qwen models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Qwen3 Embedding does not load in 0.10.0 - There is no module or parameter named 'layers' in Qwen3ForCausalLM

2 participants